react-sortable-hoc Allow SortableContainer to be parent of Sort Helper via 'useContainerAsSortableHelperParent' prop

Allow SortableContainer to be parent of Sort Helper via 'useContainerAsSortableHelperParent' prop

Open famani3 opened this issue 7 years ago • 7 comments

Updated SortableContainer to take an additional property to allow the developer to choose if he/she want to have the Sortable Helper appended to the SortableContainer's element instead of appending to the end of the body

Fixes #192

Apr 20 '17 20:04 famani3

Hey @famani3,

Thanks for submitting this PR. If you don't mind making changes to your PR, I think it'd be best to be able to pass in any DOM node as the parent instead and have it default to document.body

This would definitely be a use at your own risk kind of feature though.

Apr 27 '17 01:04 clauderic

Yeah, I will make the necessary changes once I have some time to complete them.

On Wed, Apr 26, 2017 at 9:49 PM Claudéric Demers [email protected] wrote:

Hey @famani3 https://github.com/famani3,

Thanks for submitting this PR. If you don't mind making changes to your PR, I think it'd be best to be able to pass in any dom node as the parent instead and have it default to document.body

This would definitely be a use at your own risk kind of feature though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clauderic/react-sortable-hoc/pull/194#issuecomment-297588777, or mute the thread https://github.com/notifications/unsubscribe-auth/AGEzShndIijR2CcZdR3Zfw7z1j3OIHNSks5rz_QxgaJpZM4NDgyx .

-- Faried Amani

Apr 27 '17 14:04 famani3

Any updates on this? Implementing sortable table rows and this would really help!