react-native-highlight-words icon indicating copy to clipboard operation
react-native-highlight-words copied to clipboard

Update the package to use deprecated-react-native-prop-types and keep compatibility with react native 0.69.x

Open mrcandido opened this issue 3 years ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

This package stopped working after upgrading react native to 0.69 due to ViewPropTypes being deprecated and removed from react native. Updating the package to use "deprecated-react-native-prop-types" resolved the issue.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-highlight-words/index.js b/node_modules/react-native-highlight-words/index.js
index e15cc90..4dab0dc 100644
--- a/node_modules/react-native-highlight-words/index.js
+++ b/node_modules/react-native-highlight-words/index.js
@@ -2,14 +2,15 @@ import React from 'react';
 import {Text} from 'react-native';
 import {findAll} from 'highlight-words-core';
 import PropTypes from 'prop-types';
+import  { TextPropTypes} from 'deprecated-react-native-prop-types';
 
 Highlighter.propTypes = {
     autoEscape: PropTypes.bool,
-    highlightStyle: Text.propTypes.style,
+    highlightStyle: TextPropTypes.style,
     searchWords: PropTypes.arrayOf(PropTypes.string).isRequired,
     textToHighlight: PropTypes.string.isRequired,
     sanitize: PropTypes.func,
-    style: Text.propTypes.style
+    style: TextPropTypes.style
 };
 
 /**

This issue body was partially generated by patch-package.

mrcandido avatar Aug 23 '22 14:08 mrcandido

it was fixed by multiple PR's like https://github.com/clauderic/react-native-highlight-words/pull/31 and https://github.com/jacargentina/react-native-highlight-words/commit/5d46297549366793b13c9be99be13fd2a3bbbb1a but these changes never got released

harisbaig100 avatar May 09 '24 09:05 harisbaig100