react-infinite-calendar icon indicating copy to clipboard operation
react-infinite-calendar copied to clipboard

docs duplicate some months, miss others

Open dimitropoulos opened this issue 6 years ago • 11 comments

image

http://clauderic.github.io/react-infinite-calendar/#/customization/select-year-first?_k=0pth0m

dimitropoulos avatar Sep 12 '17 13:09 dimitropoulos

What browser are you using / which timezone are you in?

clauderic avatar Sep 12 '17 13:09 clauderic

I'm getting the same error in the US (east coast)

michaelolo24 avatar Sep 15 '17 22:09 michaelolo24

chrome in ET

dimitropoulos avatar Sep 15 '17 23:09 dimitropoulos

I had the same when selected was moment.toString() value. Helped replacing by native js Date object 😎

EDIT: no. It didn't help 😞

talibasya avatar Oct 13 '17 16:10 talibasya

Same problem in Chrome 62 OSX, NZDT (+1300), the component was initialised with selected (regardless of being an ISOString or a Date) and display="years" and onSelect, width, height.

image image image

layerssss avatar Oct 25 '17 22:10 layerssss

I believe this is the issue https://github.com/clauderic/react-infinite-calendar/blob/master/src/Years/index.js#L53

and https://github.com/clauderic/react-infinite-calendar/blob/master/src/utils/index.js#L160 If the selected date is out of range for the month, the next month is returned.

meta-meta avatar Oct 31 '17 18:10 meta-meta

Hey we're also having this issue! I see that @mvayngrib committed a fix. Does that solve it.? It hasn't been merged for a release right?

leron8 avatar Jun 26 '18 12:06 leron8

@leron8 I've had a PR open for 8 months. https://github.com/clauderic/react-infinite-calendar/issues/150 It fixes the issue.

meta-meta avatar Jun 26 '18 14:06 meta-meta

Thanks @meta-meta , how could I use that fix? would I have to fork this repo and build it myself or is the only option to wait for the pull request to be merged?

leron8 avatar Jun 26 '18 16:06 leron8

@leron8 Yes, I believe that's the only thing you can do until it's merged and published. If you want, feel free to use my fork by adding this to your package.json: "react-infinite-calendar": "meta-meta/react-infinite-calendar#built",

meta-meta avatar Jun 26 '18 16:06 meta-meta

great @meta-meta I see that it's the only change you comparing to the original repo right? https://github.com/clauderic/react-infinite-calendar/compare/master...meta-meta:master ... well besides this: https://github.com/clauderic/react-infinite-calendar/commit/d32f20c6e26bfcca2fb67854c90f4d82a91c3cb6 but it only changes README.md

leron8 avatar Jun 26 '18 16:06 leron8