core icon indicating copy to clipboard operation
core copied to clipboard

build(deps): Bump ibc-go from 7.4.0 to 7.4.1

Open inon-man opened this issue 1 year ago • 4 comments

Summary of changes

  • Bump ibc-go to classic-terra/[email protected] and go version to 1.22
  • Fix golangci-lint
  • Update Mergify rules for backporting

(FOR ADMIN) Before merging

  • [x] Added appropriate labels to PR
  • [x] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • [x] Confirm added tests are consistent with the intended behavior of changes
  • [x] Ensure all tests pass

inon-man avatar Jul 31 '24 07:07 inon-man

Looks good from my side. Thanks for the contribution! I presume this is a state machine breaking upgrade, is it not? In this case due to the decentralized nature of Terra Classic the current "standard procedure" to do such an upgrade is to force a chain halt through an upgrade proposal and then install the new client with an empty upgrade handler in place... In this case the PR would lack of an upgrade handler... Maybe you can give a bit feedback on this matter?

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

inon-man avatar Aug 01 '24 15:08 inon-man

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

When looking at the code diffs from 7.4.0 I would assume it could be state breaking due to different handling of events.

StrathCole avatar Aug 01 '24 16:08 StrathCole

There are no breaking changes. See https://github.com/cosmos/ibc-go/blob/v7.4.1/CHANGELOG.md#v741---2024-05-22

When looking at the code diffs from 7.4.0 I would assume it could be state breaking due to different handling of events.

Emitting events doesn't break the state. You can test it by adding any events after any messages

For example when I added a test event after in the SendCoins function in my local

	ctx.EventManager().EmitEvents(sdk.Events{
		sdk.NewEvent(
			"test",
			sdk.NewAttribute("attr1", "1"),
		),
	})

The result of querying the tx:

height: 18800267,
txhash: 'B6284253928FB8F3CF641B6A53979E9C3E6669E0AA8D93445FB6286344D85E64',
raw_log: '[{"msg_index":0,"events":[{"type":"message","attributes":[{"key":"action","value":"/cosmos.staking.v1beta1.MsgDelegate"},{"key":"sender","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"module","value":"staking"}]},{"type":"coin_spent","attributes":[{"key":"spender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"coin_received","attributes":[{"key":"receiver","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"transfer","attributes":[{"key":"recipient","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"sender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"},{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"}]},{"type":"message","attributes":[{"key":"sender","value":"terra1jv65s3grqf6v6jl3dp4t6c9t9rk99cd8pm7utl"}]},**{"type":"test","attributes":[{"key":"attr1","value":"1"}]}**,{"type":"withdraw_rewards","attributes":[{"key":"amount","value":"1074uidr,3ujpy,4941ukrw,6207800uluna,2umyr,1uthb,17787uusd"},{"key":"validator","value":"terravaloper1259cmu5zyklsdkmgstxhwqpe0utfe5hhyty0at"},{"key":"delegator","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"}]},{"type":"coin_spent","attributes":[{"key":"spender","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1991000000000uluna"}]},{"type":"coin_received","attributes":[{"key":"receiver","value":"terra1fl48vsnmsdzcv85q5d2q4z5ajdha8yu3nln0mh"},{"key":"amount","value":"1991000000000uluna"}]},{"type":"delegate","attributes":[{"key":"validator","value":"terravaloper1259cmu5zyklsdkmgstxhwqpe0utfe5hhyty0at"},{"key":"delegator","value":"terra1lmxals6fp5c74cmkd3vnrxgy7r2tyjdtuaek58"},{"key":"amount","value":"1991000000000uluna"},{"key":"new_shares","value":"1991000000000.000000000000000000"}]}]}]',

Which type:"test" can't be found on https://finder.terraclassic.community/mainnet/tx/b6284253928fb8f3cf641b6a53979e9c3e6669e0aa8d93445fb6286344d85e64

inon-man avatar Aug 01 '24 23:08 inon-man

I don't think these should be applied immediately. I was thinking about making them included by governance in the future.

inon-man avatar Aug 02 '24 01:08 inon-man

closed - outdated

fragwuerdig avatar May 09 '25 10:05 fragwuerdig