core
core copied to clipboard
classic-terra
[BUG] Astroport Smart Contract Update
Describe the bug Astroport has stated that they will not update their existing smart contract to support parity. An solution to provide the ability for end-users to swap LUNC to and from USTC is required.
Interesting. It remind me to start thinking strategically about how to deal with existing dApps in the future. What should we do with native tokens left in dApp wallets?
@inon-man this is definitely a philosophical question, and I think we'll need to set up a separate issue as a discussion thread for it -- with respect to native tokens left in dApp wallets. Another example, what should be done with the value locked in MIR? Both are really good discussion items.
https://github.com/astroport-fi/astroport-core/tree/terra_classic
@inon-man this is definitely a philosophical question, and I think we'll need to set up a separate issue as a discussion thread for it -- with respect to native tokens left in dApp wallets. Another example, what should be done with the value locked in MIR? Both are really good discussion items.
Agreed. I think the community needs a debate on this.
based on this deprecation warning: https://github.com/classic-terra/cw-storage-plus/blob/38e23673958b5e56f2138ca9c1e893cfd4d90034/src/keys.rs#L342
maybe, there is a chance that u64 and U64Key is the same. Nope, it can't be the same.
However, there is a version that matches with current wasmd which has legacy supports for U64Key: cw-storage-plus = "0.11.1"
Testing about this specific case at: https://github.com/nghuyenthevinh2000/contract-playground/tree/main/contracts/u64key-migrate
Looks like decent progress, I'm going to make an issue here that sort of just like collects whining from the community and let's go from there
U64Key and u64 is compatible, tests have been done with following scenario:
- instantiate old contract
- query from storage with U64Key
- migrate
- query from storage with u64
- execute on storage with u64
- query from storage with u64
