Christian Clason
Christian Clason
As highlighting is now "owned" by core, this should be done here unless there's a plan for iterating a lot.
_Your_ convenience, at the cost of _our_ inconvenience. Two lines instead of one does not justify the additional implementation, documentation, maintenance, and testing effort.
> I think the problem is not the costs, but whether LspAttach return client directly is acceptable or not in design. And whether it is depends exactly on the cost......
You might want to look at how https://github.com/qvacua/vimr does it (which to my knowledge is the only current serious user of `libnvim`). The sources are modified, though: https://github.com/qvacua/neovim
OK, I see. I think the code changes are OK in this case. The second commit should be `docs(shared)` or `docs(lua)`, though. (Best to wait for CI to finish before...
This is a standard and well-known issue with treesitter for huge files. Work to mitigate this is in progress (e.g., https://github.com/neovim/neovim/pull/19812) but not trivial.
Like https://github.com/kevinhwang91/nvim-ufo/, investigate whether we can extract and apply treesitter highlights (extmarks) to the foldline as well.
Yup, just wanted to note it somewhere, and here was as good a place as any. (Not purely orthogonal, though, since your suggestion would mean everything stayed in "extmarks land"...
>> Allow nvim_create_namespace() as an augroup ? > This seems reasonable. This has been requested before, but needs to be thought through _very_ well or it will turn into a...
@BK1603 sorry that this was left on the back burner for 0.7. Are you still available and interested in continuing this? A rebase would be a good start ;)