Christian Clason

Results 1361 comments of Christian Clason

Yes, that sounds reasonable. Can you test it and open a PR if it fixes that?

We may need to bundle one of the utf8 libraries listed at the end of http://lua-users.org/wiki/LuaUnicode to get this (and other cases) working correctly, either * https://github.com/alexander-yakushev/awesompd/blob/master/utf8.lua (minimal, pure Lua)...

> It seems that none of the functions have their return value type documented, is that intentional? It's not; documentation is lacking since tree-sitter support is still experimental and in...

bump -- do we still want this for 0.8?

I don't think these patterns _are_ tested...

Just for the sake of completeness, what about the original option of having a different table for "environment patterns"? (The 5% increase for just checking the first character is acceptable;...

> I have updated the results, seems like not using a metatable really was a good idea :D Does this include the separate `pattern_env` table that is expanded unconditionally? (Hard...

I would have expected that they could just add to the same table in vim.filetype.add?

My suggestion was under the assumption that it would make things easier, not harder. Let's go with https://github.com/neovim/neovim/commit/189ff56c655392f62bc530356b05c0c0f62a347f then.

bump -- last big treesitter PR for 0.8?