Christian Clason
Christian Clason
aaand the crash is back. apparently the bug can tell if automerge is enabled.
> You are changing libvterm too Yes, because there is shared code, and shared problems.
Note for later: as we're taking ownership of `vterm` by integrating it more tightly with Neovim utf8 functionality (to guarantee that core and embedded terminal have the same idea of,...
Not sure we want to yeet all debug output? That can be helpful. (Although we can definitely improve that, and hook into Neovim's own `NDEBUG` instead.)
I think (slowly) moving utf8-related code to be in sync with Neovim is absolutely worth it. Stylistic polish and dead code removal is low-effort/low-reward by comparison, though (albeit not unwelcome).
@dundargoc rebase, and possibly look into using more utf8 code after bfredls bobbytablectomy (not necessarily in this PR)? Would like to move forward with (slowly) cleaning up the inherited code.
@dundargoc do you want to squash (some of) the commits?
Yes, diffsitter looks like the way to go here. It shouldn't be too hard to port that to an [nvim-treesitter module](https://github.com/nvim-treesitter/nvim-treesitter#adding-modules) (starting from https://github.com/nvim-treesitter/module-template), which would be the right place...
We wouldn't use diffsitter directly but use the same algorithm to generate a diff using tree-sitter. The display would still use the standard vim functions (although they may have to...
what is your _exact_ locale?