clash-compiler icon indicating copy to clipboard operation
clash-compiler copied to clipboard

Clash.Hedgehog.Sized.BitVector.genDefinedBitVector should not use genVec

Open lmbollen opened this issue 2 years ago • 1 comments

Using genVec internally in genDefinedBitVector is incredibly slow and should be replaced. I think Hedgehog.Gen.intergral would significantly speed up generation..

lmbollen avatar May 16 '22 12:05 lmbollen

Be sure to test whether these generators generate numbers >= 2^63 for BitVector n where n => 64. It might rely on Enum internally which ~~is a severely broken class that in its current form should be banished from Haskell~~ can lead to surprising behavior.

martijnbastiaan avatar May 16 '22 12:05 martijnbastiaan