Bryan Clark

Results 59 comments of Bryan Clark

I'd be happy to review a PR! 😄

> Noticed just now that this seems to be a Chrome specific thing and does not work with Firefox extensions. Is this something that's still relevant for this project? Otherwise...

> Can someone look at this PR? Looking for the support this code would provide. rebasing but this likely requires a lot more attention

I need to double check the bundler behaviour but GitHub sources are required to have a namespace. For example: ```ruby source "https://rubygems.pkg.github.com/github" source "https://rubygems.org" gem "rails" gem "@github/rube" ``` The...

I've asked for this before. I'll push for it again.

In the short term can we only filter out the login message?

> Perhaps this project doesn't support typescript testing? If so, maybe I could `declare` something for the functions I'm using. I just want to make sure I'm not misunderstanding something...

In the [storage.local](https://github.com/clarkbw/jest-webextension-mock/blob/main/src/storage.js#L60) module if you add a similar onChanged object to [this](https://github.com/clarkbw/jest-webextension-mock/blob/main/src/storage.js#L134-L138) and corresponding tests I could approve that.