KnitUI icon indicating copy to clipboard operation
KnitUI copied to clipboard

Published 20 hours ago • verified publisher icon clarisights

refactor: remove dependency on "rc-dialog" & "rc-switch"

Open pranshuchittora opened this issue 5 years ago • 11 comments

Hi there, Great work on creating an awesome component lib cum design system. :clap: :confetti_ball:

Description

The switch has a dependency of rc-switch https://github.com/clarisights/KnitUI/blob/acb3221e04f788d51a3a0513c3259cd69daebab9/src/components/Switch/styledComponents.tsx#L1

Similarly, Modal too has a dependency of rc-dialog https://github.com/clarisights/KnitUI/blob/fa9ab8c754f52f5997102381282027945ee9d4b6/src/components/Modal/ModalWrapper.tsx#L3

I think the components should be decoupled from such dependency.

What can be done?

  • Custom implementation can be done (could make a difference in the long run :rocket: )

Let's discuss :loudspeaker:

pranshuchittora avatar Nov 17 '19 09:11 pranshuchittora