ParlaMint icon indicating copy to clipboard operation
ParlaMint copied to clipboard

Data

Open matyaskopp opened this issue 1 year ago • 5 comments

matyaskopp avatar Dec 04 '24 09:12 matyaskopp

@matyaskopp, what's happening to the checks? Are they stuck or merely take so long?

TomazErjavec avatar Dec 06 '24 22:12 TomazErjavec

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

matyaskopp avatar Dec 07 '24 08:12 matyaskopp

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

@matyaskopp, indeed, it did finish now, now checks are failing for some countries (e.g. EE, FR). However, I can't see why, maybe you can? It would be good (and expected) if the checks succeeded.

TomazErjavec avatar Dec 07 '24 09:12 TomazErjavec

@TomazErjavec I had to trigger the action again with empty commit, now it seems to work

@matyaskopp, indeed, it did finish now, now checks are failing for some countries (e.g. EE, FR). However, I can't see why, maybe you can? It would be good (and expected) if the checks succeeded.

They are failing due to incomplete translations - I have switched to insisting on translations. https://github.com/clarin-eric/ParlaMint/blob/5f13b36d9421b25f96a9e600b29705dd5a629fa7/.github/workflows/validate.yml#L60 it is customisable in settings: https://github.com/clarin-eric/ParlaMint/settings/variables/actions image

Now we have IL fully translated, so I can switch it off if we don't want to motivate others to deliver their translations

matyaskopp avatar Dec 07 '24 09:12 matyaskopp

@matyaskopp, thanks for explaining and illustrating!

Now we have IL fully translated, so I can switch it off if we don't want to motivate others to deliver their translations

I don't think they will be motivated by this, if they haven't done it in the scope of the project, they won't now either. On the other hand this makes it more difficult to find other problems. So, yes, I'd switch it off, at least for now. And - despite the explanation of how to do it - I'd rather let you press the magic button.

TomazErjavec avatar Dec 07 '24 10:12 TomazErjavec