Clare Singer
Clare Singer
A starting point will be to check the entire profile of T(z), p(z), S(z) against the Pyrcel model results. Suspect 1: https://github.com/open-atmos/PySDM/blob/main/PySDM/physics/state_variable_triplet/libcloudphplusplus.py
e.g. see how it is currently done here https://github.com/CliMA/CloudMicrophysics.jl/blob/ces/ARGplots/docs/src/ARGplots.jl
Following up here after a discussion with @jtbuch last week... My original suggestion was actually a bit different from what is described above as method 2. I'd call it something...
Hi @slayoo! Thank you - this looks like an awesome first step. I see that you have implemented a time window for the seeding, but not yet a variable for...
Yes, great! Just adding my two cents on what will be the interesting/physically relevant extensions to work on next. And hopefully my comments on the #1367 are helpful, too.
Both of these papers look like good examples to start with because the Parcel environment will be easier than a 1D case to start. The LES is more complex than...
Concrete next steps are outlined in issue #1387
Some sanity check tests to add in might be 1) checking that turning on Seeding dynamic but having time_window=0 yields the same results as no seeding, 2) checking that all...
@slayoo I tried to write a unit test for the Seeding dynamic. It's here. https://github.com/claresinger/PySDM/blob/sd_injection/tests/unit_tests/dynamics/seeding/test_parcel_seeding_sanity_checks.py I'm not sure I have permissions to commit changes to this PR... or at least...
Hi @slayoo - thanks so much for all the work here! Sorry for the delay - I've been away on a hiking holiday :) Things are looking great. I agree...