clappr-core icon indicating copy to clipboard operation
clappr-core copied to clipboard

Add tap and dbltap events

Open EternalPatience opened this issue 1 year ago • 0 comments

Summary

This pull request introduces two new custom events, CONTAINER_TAP and CONTAINER_DBLTAP, and updates CONTAINER_CLICK and CONTAINER_DBLCLICK to be triggered alongside their respective original events. The new custom events have potential utility for distinguishing player behavior on mouse versus touch events. For instance, a CONTAINER_TAPevent could be used to display media controls on the first tap and trigger stop/play on the second.

Furthermore, this PR includes an additional argument for the trigger touch and click events of the container, which provides the original event. This enhancement could prove valuable for scenarios where HTML elements have already been created by other plugins and nested in a Container, and differentiation is required between the triggered events.

Changes

  • src/base/events:
    • events.js
  • src/components/container:
    • container.js
    • container.test.js
  • src/utils/:
    • utils.js
    • utils.test.js

How to test

Try binding CONTAINER_TAP/CONTAINER_DBLTAP/CONTAINER_CLICK/CONTAINER_DBLCLICK with listenTo

EternalPatience avatar Mar 17 '23 14:03 EternalPatience