wdrp icon indicating copy to clipboard operation
wdrp copied to clipboard

Published 20 hours ago • verified publisher icon clandrew

Allow Discord status to NOT update when stopped/paused

Open derekgates opened this issue 5 years ago • 8 comments

  • Add setting for "SendStatusWhenPausedOrStopped" that instructs Discord that the application is no longer 'active'. Defaulted to false which matches Spotify behavior; only reporting something when actively playing.
  • Settings dialog updated for this setting with checkbox.
  • Default setting stored in settings.ini
  • Discord RPC disconnected when in pause/stop setting and reconnected.
  • Connection status reported by Discord callback itself.

I used my previous branch work for VS Code integration (as that is how I am developing this), so this PR looks a little funky until that is merged. My apologies.

There is a new screenshot of the dialog included in Images that can be linked in the README.md (and the link to COLLABORATING.md also needs fixing I realized).

fixes #12

derekgates avatar Feb 27 '20 06:02 derekgates

Thanks for doing this! Overall looks good, but I'll take a closer look this weekend when I'm on my dev computer.

clandrew avatar Feb 28 '20 04:02 clandrew

No problem!

Hopefully it is to your standards; I tried using the same code formatting and style and modified as little as possible to achieve this.

If my other PR is merged I will rebase this against master to reduce the clutter in this PR. :)

derekgates avatar Feb 28 '20 04:02 derekgates

Bleh, I was trying to use GitHub Desktop to merge and remove the VS Code related PR that was merged into master but looks like I need to rebase to remove that extra clutter from this PR. Still getting the hang of that...

derekgates avatar Feb 29 '20 23:02 derekgates

I did a quick test of this change locally and it looks good! Thank you @derekgates :) None of my comments are blocking. The only thing that seems a bit weird is the commit history. Did you still want to do stuff with the commit history? Either way I'm ready to merge. If you can't get around to cleaning the history I can sort it out no worries.

clandrew avatar Mar 01 '20 18:03 clandrew

The only thing that seems a bit weird is the commit history. Did you still want to do stuff with the commit history?

Indeed. I have this problem at work as well; if you chain a PR on another pending PR then the history gets crazy.

This time I used GitHub Desktop and made a branch from a previous branch, I expected to be able to rebase against master and have the duplicated changesets be removed. I am missing something... Any ideas?

derekgates avatar Mar 02 '20 16:03 derekgates

That's a tough one. How I would fix it personally is do a branch reset back to where the branch was created off of the remote, then create 1 or 2 new clean commits, then force push. All to your private branch. This has the power to effectively delete commits and re-write history. Re-writing history could cause weirdness with the PR but that's okay.

I know how to do the above in Git Extensions, that's the client I'm used to, but unfamiliar with other clients. If you prefer I can merge this new and fix it up on your behalf.

clandrew avatar Mar 02 '20 17:03 clandrew

I haven't forgotten about this PR or project. I cleaned up the PR for recommendations and have been attempting some git rebase work to try to clean up the history.

At this point I think a squash would be helpful... the merge to master SHOULD resolve any duplication?

derekgates avatar Mar 10 '20 15:03 derekgates

Hey, coming back to this- I'm still interested in taking this PR- if it's alright with you, I was going to try and merge it this evening. Yeah, as a squash commit. Although in general i'm not an extreme stickler for clean commit history esp for small projects like this

clandrew avatar Nov 13 '20 22:11 clandrew