clalancette
Fix mistake in spec file
- Fix for running on python3 and building on EL8 or higher
- replace 'or' keyword with proper '||'
Hi @nullr0ute - sorry to bother.
One of these changes is to fix a breakage in the spec by my last PR - apologies for that.
I'm happy to split this into multiple PRs if you'd prefer. I did test this on multiple OS types and can confirm the change from self.config.useuefi to self.useuefi in the Guest class does not appear to affect how the Fedora subclass is passing it in. Additionally, it lets RHEL 8 and 9 guests boot with UEFI on x86 without passing in a FedoraConfig class.
Best, Neil
I'm glad you tested it this time. For reference we've been using this prior to it for some time on Fedora without issues with py3 etc.
Instead of commit e227813fa1c7e45d6f44545d609434993fdbce45 please do like this https://github.com/clalancette/oz/pull/304 - that way useuefi can be overriden from config file instead of having to modify get_class() core components or all distro classes.
@tobias-urdin Great idea. Mine was a hacky fix without reading too much of the code base. I've dropped that commit in favor of your #304.
This can probably be merged as well as yours. I've tested it in my setup and it works as expected.
Thank you!