Chris Laco

Results 64 comments of Chris Laco
trafficstars

"# See rhbz #432903 for reasoning." Please put the reasoning, issues, etc in this issue, so the next person months from now doesn't have to go on a spelunking safari...

@rackerjoe @cfarquhar Most likely, this needs to be sorted to it is rendered the same each time: https://github.com/rcbops-cookbooks/horizon/blob/v4.1.5rc/recipes/server.rb#L68 @cfarquhar Can you run a diff between the file created `/etc/apache2/ports.conf` and...

In fact, we're laying down ports twice, once in horizon as a resource rewind of apache2s version, and once in graphite as a clone. https://github.com/rcbops-cookbooks/graphite/blob/master/recipes/graphite.rb#L101

@cfarquhar Thank you sir. That will definitely help in tracking this down. out of curiosity, do both versions work (with, and without 0.0.0.0:)?

This is why chef-edit exists. But cloning is usually the least of our problems. In the spc book, we do `resources :type => "name"` directly and have no clone warnings.

Clones are mistakes. If your cookbook creates a clone, edit the resource instead. If upstream does, patch upstream. This is the game. I'm not saying it's great. So, the other...

For future readers: we use this pattern in just two places: https://github.com/rcbops-cookbooks/cinder/commit/358ce9cc61790e7c769b4d21bc8578346b706fc3 https://github.com/rcbops-cookbooks/nova/commit/c0c6a0ffe6a90ee16bab6ce931d52c2f2aeb219e We think the origin is here: https://github.com/rcbops-cookbooks/openstack-ha/blob/master/recipes/default.rb#L81

Here's my guess: ``` r = template "vrrp_#{new_resource.name.upcase}" do ``` openstack-ha calls that provider in a loop, and if the v*ps are the same for each service, we're creating a...

Thank you for your updates. Unfortunately at this time, our main cookbooks (https://github.com/rcbops/chef-cookbooks) are pinned at the last 2.x release. In the case of this repos Vagrant/Test-Kitchen support, we can't...

Go ahead and leave it open. We'll be revisiting this after the holidays at some point.