lrzip icon indicating copy to clipboard operation
lrzip copied to clipboard

fix build failed on macos

Open leleliu008 opened this issue 2 years ago • 5 comments

close #203

leleliu008 avatar Jul 04 '21 16:07 leleliu008

Generally, people who package lrzip would tailor its settings. The changes you suggest are not appropriate for a wide audience. I would make this a local change for your fork.

pete4abw avatar Jul 05 '21 18:07 pete4abw

the macOS user can't build lrzip 0.641 successfully. https://github.com/Homebrew/homebrew-core/pull/71422 HomeBrew still using lrzip 0.631 due to this problem. https://github.com/Homebrew/homebrew-core/blob/master/Formula/lrzip.rb

leleliu008 avatar Jul 05 '21 19:07 leleliu008

Just do ./configure --disable-asm. Removing @echo will break things. I have resolved other homebrew issues although I don't know anything about that build system. Your patch will not solve your issue. --disable-asm will.

pete4abw avatar Jul 05 '21 19:07 pete4abw

I'm not just removing @echo but replacing @echo with printf , you should see Files changed. this patch have been tested on my local mac, It can be successfully built.

leleliu008 avatar Jul 06 '21 04:07 leleliu008

Glad it works for you. Certain shells do not support all echo commands. /usr/bin/echo should work as advertised. I don't think I will adopt it. Better solution is to not have to kludge it at all. But automake assembly support does not support pure asm files. That is where I will put my effort. Removing the SUBDIRS could affect how make dist operates.

pete4abw avatar Jul 06 '21 14:07 pete4abw