ckohen comments

Results 49 comments of


                                            ckohen

Invalid webhooks tokens

Possibly related to https://github.com/discord/discord-api-docs/issues/5558

formStore.setError() with nested values completely broken

Happy to make a PR for this, just need to know whether to simply remove the Array / Object check or add an extra param to dictate when to skip...

KV Key metadata types too narrow

The associated code has still not been touched and still has this issue

KV Key metadata types too narrow

This has not been addressed yet

KV Key metadata types too narrow

Will close with the next PR that merges release / next to main

[node] Cleanup generics of EventEmitter and correct types

That is not the only root cause, and has nothing to do with the `this` type. This is observable without classes ```ts type Foo = { callable(str: K): number; }...

[node] Cleanup generics of EventEmitter and correct types

This PR does not contain the changes that caused the major issues with outdated targets, they will be added in a separate PR so that this cleanup can be done...

[node] Cleanup generics of EventEmitter and correct types

It seems this PR is illustrating some of the major shortcomings (and tbh bugs) of typescript. You neglected the assignability issue that applies to instances that have generics set which...

[node] Cleanup generics of EventEmitter and correct types

And....that broke everything. Every single failed test illustrates exactly why this needed to be done natively instead of the current fragmented ecosystem. I'll revert this tomorrow so that people have...

[node] Cleanup generics of EventEmitter and correct types

I know this is broken in a known way, just adding tests for the cases that broke last time and going back to something that was a little closer to...