kevedit icon indicating copy to clipboard operation
kevedit copied to clipboard

Testing a #play command displays garbage if more #play commands follow it

Open niconii opened this issue 1 year ago • 2 comments

In KevEdit 1.2.0, create a new object and write the following code:

#play cdefgab
#play eeee

Move the cursor to the first line and press Ctrl+T. For some reason, while the music is playing, the first line is displayed as #play ceeega, though it doesn't seem to affect the actual music played, and it reverts back after the music finishes.

This happens for me in both the Linux and Windows versions, though not DOS for some reason.

niconii avatar Jun 15 '23 06:06 niconii

Confirmed.

The linux/windows/mac music player is almost completely different than the dos version. I'm going to look into trying to make the former work more like the latter.

cknave avatar Jun 16 '23 02:06 cknave

This looks to have been broken ever since the switch from SDL 1 to 2. The music player loops without ever handing control over to getch(), which is where we normally present the display buffer.

I have a fix in my updated music player branch: https://github.com/cknave/kevedit/pull/51/commits/43c2eb14d82e853afdab28fc018cf9476703dbe7

It still needs some work before it can be merged, but I'm expecting to finish it up soon.

cknave avatar Jun 21 '23 01:06 cknave