LockCheck icon indicating copy to clipboard operation
LockCheck copied to clipboard

dotnet tool?

Open KirillOsenkov opened this issue 1 year ago • 5 comments

@cklutz once again thank you for creating this indispensable library!

Have you thought about publishing a dotnet global tool like lockcheck.exe such that you could run it from command line?

Long ago this used to be a console .exe project, but now it seems to be a library only?

KirillOsenkov avatar Aug 23 '24 18:08 KirillOsenkov

I pushed a branch in my fork if you're interested: https://github.com/KirillOsenkov/LockCheck/tree/tool

KirillOsenkov avatar Aug 23 '24 18:08 KirillOsenkov

I published https://www.nuget.org/packages/lockchecktool and added you as an owner if you're interested. Happy to make a PR to this repo too.

KirillOsenkov avatar Aug 23 '24 19:08 KirillOsenkov

There you go!

image

KirillOsenkov avatar Aug 23 '24 19:08 KirillOsenkov

Oh yes, nice idea. Haven't thought about that. Go figure! :-)

I'm a bit busy for the next couple of weeks, but after that (or before, if possible at all), I'd gladly like to merge a PR. Thanks for the ownership offer. I accepted it in the hopes I can provide some value eventually.

cklutz avatar Aug 26 '24 10:08 cklutz

Here you go: https://github.com/cklutz/LockCheck/pull/11

no rush!

KirillOsenkov avatar Aug 27 '24 03:08 KirillOsenkov

Finally :-) I merged it. Sorry for taking so long and thanks again! I will have to do some more work on this library in the next weeks (hopefully) the Linux tests are (still) broken and some other stuff...

I will close this issue for now, but feel free to let me know if we need to do some more things about this (tool).

cklutz avatar Oct 01 '24 10:10 cklutz

.

cklutz avatar Oct 01 '24 10:10 cklutz