Charles Kerr

Was the color change part of some larger change that we need to think about here -- e.g. are there other places that colors need to be reverted at the...

> does someone have any before after screens https://github.com/transmission/transmission/pull/4813/files/a4bc2e6b74d3b289fb38997860bc82bfb5e773d6..e00fc6e405a9ad70a218e614afc331b5d78508a1 shows the before and after between 4.0.0 and this PR, but of course not 3.00

> I saw the criticism of the whiteness of the text and icons of the web interface and agree with the comment that was made, it currently excels accessibility-wise and...

> oops... I posted iOS colors. heres macOS, Green is slightly different: FWIW, this is why I trust other people to do UI review. These look so close to each...

The main point that would need to be considered is the `sitename` field in the struct returned by tr_urlParse(). This has made its way into several places, e.g. in RPC,...

> Put another way: the client GUI should take responsibility for the PSL outcome, not the RPC api. The tradeoff is that instead of maintaining 1 implementation, we would have...

It's true that there is already a lot of duplication and the idea of a libtransmissionapp library that has the nonessential shared functions has been discussed but so far never...

> Understood. My only lingering concern is that once this gets usage (by third-parties) via the RPC API there is danger in removing. The time to think about that was...

One of the macOS volunteers will need to speak up about how this happens in that client :eyes:

> On the initial transmission-daemon startup with a missing settings.json configuration file, the daemon generates one. However, that file does not contain all the existing directives, but merely a subset...