Charles Kerr
Charles Kerr
Hi @ryanthemanuel! Planned breaking changes to Electron are listed out in https://www.electronjs.org/docs/latest/breaking-changes. I don't see anything there about memory changes in 22, though if you're upgrading from
CC @Pentaphon or @GaryElshaw
@mikedld has been the primary on the GTK code, so I'd rather not go around him. @mikedld do have bandwidth to do a review on this?
Closing due to lack of update. Anyone who would like to add this feature, please feel free to open a new PR.
@Coeur or @GaryElshaw could you add a release note for this PR?
I think @belovachap is right; closing as fixed
Regardless of the merits of the idea, the patch predates the C++ rewrite and the author of the patch has moved on and is not interested in updating it, so...
Note that flatback [just patches around around this now](https://src.fedoraproject.org/rpms/transmission/c/6a9ac18903735abd2a55cdad65f45c53bee5a3d6?branch=rawhide): ```diff diff -up transmission-4.0.0/gtk/Application.cc.orig transmission-4.0.0/gtk/Application.cc --- transmission-4.0.0/gtk/Application.cc.orig 2023-01-30 06:23:05.000000000 +0100 +++ transmission-4.0.0/gtk/Application.cc 2023-02-15 20:49:40.137166535 +0100 @@ -700,7 +700,7 @@ std::string get_application_id(std::stri...
@mikedld thoughts on how to resolve this PR? It was submitted in Feb 2019 so I feel like that's long enough to have decided... :smile_cat: