ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Unsupported css selector :is

Open nestle49 opened this issue 1 year ago • 9 comments

📝 Provide detailed reproduction steps (if any)

  1. Include CKEditor 5 to vite/vue project
  2. Build
  3. Get warning after build - Unsupported css selector :is

✔️ Expected result

tg_image_2249556896

nestle49 avatar Nov 14 '23 09:11 nestle49

Chrome 87 is ancient 😅 Is the target environment still correct?

wimleers avatar Nov 14 '23 18:11 wimleers

Chrome 87 is ancient 😅 Is the target environment still correct?

this is set by default https://vitejs.dev/config/build-options.html#build-target

https://github.com/vitejs/vite/blob/e0c86d4f210a302876fac280d9e79a2244e83b8b/packages/vite/src/node/constants.ts#L21

DaniilIsupov avatar Nov 15 '23 14:11 DaniilIsupov

This is most likely not related to the selector or build target but the usage of Vite. We release the CSS in packages that still requires processing (we plan to change it soon). Are you using our Vite plugin?

Witoso avatar Nov 16 '23 08:11 Witoso

Yes, I use vite plugin

nestle49 avatar Nov 21 '23 10:11 nestle49

Could you check the setup from this comment: https://github.com/ckeditor/ckeditor5/issues/9807#issuecomment-1755980661, if it works we will update the docs.

Witoso avatar Nov 23 '23 08:11 Witoso

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Feb 06 '24 03:02 CKEditorBot

problem remains unresolved

image

DaniilIsupov avatar Feb 13 '24 08:02 DaniilIsupov

Could you provide a reproducible sample? The packages are now valid ESM, and those problems were not reported elsewhere, apart from a large Vite usage.

Witoso avatar Feb 13 '24 08:02 Witoso

Could you provide a reproducible sample? The packages are now valid ESM, and those problems were not reported elsewhere, apart from a large Vite usage.

https://github.com/nestle49/minimalReproductionCKEditor

  1. Clone repo
  2. npm i
  3. npm run build

nestle49 avatar Feb 14 '24 12:02 nestle49

Sorry for the late response. I cannot actually start this, for dev and build I get missing file src/assets/sprite/generated-sprite.svg. Could you resolve?

Witoso avatar Mar 04 '24 08:03 Witoso

Sorry for the late response. I cannot actually start this, for dev and build I get missing file src/assets/sprite/generated-sprite.svg. Could you resolve?

Fixed

nestle49 avatar Mar 04 '24 09:03 nestle49

I unnecessarily went to the rabbit hole of our plugin being experimental, maybe something broke in Vite v5, etc., but no. This warning message is correct. We PostCSS our styles, and it rightfully mentions that :is will not be supported by the environments picked by Vite's defaults. Chrome 87 had :is as experimental AFAICS.

The solution to this issue for now is to bump the target, and set up a compatible environment. Later, this problem will be solved by #15502, and providing prebuilt stylesheets.

Witoso avatar Mar 04 '24 20:03 Witoso