ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Empty undo step in table (cell) properties

Open Dumluregn opened this issue 2 years ago • 2 comments

📝 Provide detailed reproduction steps (if any)

~Only present at ck/epic/2978-integrate-color-picker-with-tables.~ Reproducible at master - see https://github.com/ckeditor/ckeditor5/issues/14414#issuecomment-1611205664.

  1. Open table properties balloon.
  2. Open color input.
  3. Open color picker.
  4. Select some color in the picker and press "Cancel" in color picker view.
  5. Press "Save" in the table properties balloon.

✔️ Expected result

There's no undo step.

❌ Actual result

There's an empty undo step.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Dumluregn avatar Jun 19 '23 14:06 Dumluregn

FYI: This problem is not restricted to the color picker and already exists in production.

An empty undo step will also be created in the following situation:

  1. Open table properties balloon.
  2. Open the background color palette.
  3. Choose a color.
  4. Open the palette again.
  5. Remove color.
  6. Press "Save" in the table properties balloon.

oleq avatar Jun 28 '23 11:06 oleq

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Jun 28 '24 03:06 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Jul 29 '24 03:07 CKEditorBot