ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

[TS] tsc build is failing in ckeditor-cloud-services-collaboration

Open Witoso opened this issue 2 years ago • 1 comments

📝 Provide detailed reproduction steps (if any)

  1. Clone the repo https://github.com/ckeditor/js-nation-workshop
  2. cd meta/bonus
  3. Install deps.
  4. Remove skipLibCheck from the tsconfig.
  5. Run npx tsc.

✔️ Expected result

Project builds.

❌ Actual result

Errors, multiple ones from CCSC:

import CommentsService from '@ckeditor/ckeditor-cloud-services-collaboration/src/comments-v2/commentsservice';
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@ckeditor/ckeditor5-real-time-collaboration/src/realtimecollaborativeediting/realtimecollaborationclient.d.ts:7:41 - error TS7016: Could not find a declaration file for module '@ckeditor/ckeditor-cloud-services-collaboration/src/collaborativeeditingservice/collaborativeeditingservice'. '/Users/witold/workspace/cksource/js-nation-workshop/meta/bonus/node_modules/@ckeditor/ckeditor-cloud-services-collaboration/src/collaborativeeditingservice/collaborativeeditingservice.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/ckeditor__ckeditor-cloud-services-collaboration` if it exists or add a new declaration (.d.ts) file containing `declare module '@ckeditor/ckeditor-cloud-services-collaboration/src/collaborativeeditingservice/collaborativeeditingservice';`

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Witoso avatar May 24 '23 12:05 Witoso

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar May 24 '24 03:05 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Jun 24 '24 03:06 CKEditorBot