ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

[TS] tsc build is failing in `./collaborationhistory`

Open Witoso opened this issue 2 years ago • 2 comments

📝 Provide detailed reproduction steps (if any)

  1. Clone the repo https://github.com/ckeditor/js-nation-workshop
  2. cd meta/bonus
  3. Install deps.
  4. Remove skipLibCheck from the tsconfig.
  5. Run npx tsc.

✔️ Expected result

Project builds.

❌ Actual result

Errors, the one in collaborationhistory.

node_modules/@ckeditor/ckeditor5-collaboration-core/src/index.d.ts:10:10 - error TS2305: Module '"./collaborationhistory"' has no exported member 'default'.

10 export { default as CollaborationHistory } from './collaborationhistory';

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Witoso avatar May 24 '23 12:05 Witoso

The error is caused by:

https://github.com/cksource/collaboration-features/blob/e415f21f2d419552c3f5b01e3602f15c47104c7c/packages/ckeditor5-collaboration-core/src/collaborationhistory.ts#L3-L5

It's internal so it's not in index.d.ts, TypeScript skips the internal when compiling.

@scofalik decision needed: delete internal or don't reexport it (and in places that use CollaborationHistory import directly from its source).

Witoso avatar May 29 '23 09:05 Witoso

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar May 29 '24 03:05 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Jun 29 '24 03:06 CKEditorBot