ckeditor
Improve `shExec` function implementation in `ckeditor5-dev`.
📝 Provide a description of the improvement
Improve shExec implementation in ckeditor5-dev: https://github.com/ckeditor/ckeditor5-dev/blob/master/packages/ckeditor5-dev-utils/lib/tools.js#L25
This function is used to execute sh commands in ckeditor5 ecosystem. Right now it has ~50 lines of code, and after adding async support, it would reach ~80 lines. With the current complexity, it's hard to modify and it's easy to introduce unexpected bugs.
Task description
- Simplify the
shExecfunction implementation. - When refactoring the function, make sure that the behaviour stays the same.
[Bonus]
Consider splitting the sync and async versions into two separate functions, following the node tools convention: exec and execSync.
📃 Other details
- Browser: …
- OS: …
- CKEditor version: …
- Installed CKEditor plugins: …
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.
We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).