Custom unordered list markers are removed despite GHS
π Provide detailed reproduction steps (if any)
Configure GHS to allow list-style-type attribute:
const ghsConfig = {
allow: [
{
name: /^(?:ul|ol|li)$/u,
styles: [ 'list-style-type' ]
}
]
}
Feed the editor with HTML like:
<ul style="list-style-type: 'ΒΆ '">
<li>item 1</li>
</ul>
βοΈ Expected result
The custom list marker is preserved.
β Actual result
The custom list marker is removed from the HTML.
β Possible solution
If you have ideas, you can list them here. Otherwise, you can delete this section.
π Other details
- Browser: β¦
- OS: β¦
- First affected CKEditor version: β¦
- Installed CKEditor plugins: document lists, general HTML support
If you'd like to see this fixed sooner, add a π reaction to this post.
Works correctly for the Document lists, @jacekbogdanski any need from your side to add it to the List, etc.?
Ok, I found a case where it doesn't work. Without DocumentListProperties plugin it works correctly, with this plugin the list-style-type is lost.
Fix scope:
Given I have DocumentList, DocumentListProperties, and GHS configured, the list-style-type is preserved in the styles attributes.
Is it possible to add custom list markers in a less round-about way? I'd love to be able to extend the plugin, or better still: add configuration so that i can add custom "markers"/list-style-types
I can see 2 options, IDK which is better:
- The upcast converter for the list style attribute should not consume unknown values, those should be handled by GHS.
- The list style should allow unknown values in the model but it will not be reflected in the UI (same as
supportAllValuesoption for font family, font size, etc.)
Question from my side would be, which one brings us a step closer to the feature of custom list markers (defined maybe in the UI or by integrator) but is a good starting point to unblock current cases.
Question from my side would be, which one brings us a step closer to the feature of custom list markers (defined maybe in the UI or by integrator) but is a good starting point to unblock current cases.
I think we should go with option 2 so it will be consistent with the font features.
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.
any progress on this?
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.
We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).