ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Update `FontSizeOption` documentation

Open Semigradsky opened this issue 3 years ago • 7 comments

https://ckeditor.com/docs/ckeditor5/35.2.1/api/module_font_fontsize-FontSizeOption.html

According to example in CKEditor 5 documentation (35.2.1), upcastAlso and view are optional:

const fontSizeConfig = {
	options: [
		{
		 	title: 'Small',
		 	model: '8px'
		},
		'default',
		{
		 	title: 'Big',
		 	model: '14px'
		}
	]
};

Related ticket: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/63059

Semigradsky avatar Nov 09 '22 12:11 Semigradsky

As I see, upcastAlso is marked as optional https://github.com/ckeditor/ckeditor5/blob/656057f3b1e810eb088d1752952dbd99815f8ac0/packages/ckeditor5-font/src/fontsize.js#L61

But it doesn't look as optional in docs: image

Smth wrong with the documentation generator?

Semigradsky avatar Nov 09 '22 12:11 Semigradsky

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Nov 11 '23 05:11 CKEditorBot

Still valid

Semigradsky avatar Nov 11 '23 06:11 Semigradsky

Looks like an invalid doc comment.

Witoso avatar Nov 14 '23 08:11 Witoso

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Nov 13 '24 23:11 CKEditorBot

Still valid

Semigradsky avatar Nov 15 '24 17:11 Semigradsky

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Nov 15 '25 23:11 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Dec 15 '25 23:12 CKEditorBot