ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Highlight buttons doesn't work with a collapsed selection

Open mlewand opened this issue 2 years ago • 0 comments

📝 Provide detailed reproduction steps (if any)

  1. Open an example with latest editor and the highlight feature: https://ckeditor.com/docs/ckeditor5/35.0.1/examples/builds-custom/full-featured-editor.html
  2. Focus the editor.
  3. Place a collapsed selection anywhere in the text.
  4. Click down arrow in highlight dropdown button.
  5. Choose green marker button from the dropdown.
  6. Type "foo"

✔️ Expected result

Foo gets typed with green highlight.

❌ Actual result

No highlight is applied.

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

You can see that the highlight attribute doesn't get applied to the selection model when the button is clicked.

It got broken with 35.0.0 (or 35.0.1 if you will), works well with 34.2.0:

https://ckeditor.com/docs/ckeditor5/34.2.0/examples/builds-custom/full-featured-editor.html

  • Browser: Any
  • OS: Win10
  • First affected CKEditor version: 35.0.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

mlewand avatar Aug 09 '22 08:08 mlewand