ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Why two separate toggle caption buttons?

Open oleq opened this issue 3 years ago • 2 comments

📝 Provide a description of the improvement

Check out this scenario, the toolbar configuration includes

'toggleImageCaption', 'toggleTableCaption',

2022-08-03 13 00 43

They even have the same label. I suppose we could have a single feature (UI) for both tasks that would execute the right command (toggleImageCaption or toggleTableCaption).

Issues

  • Where do we implement this? Both features are in different packages (ckeditor5-table and ckeditor5-image)
  • Should we make is extendable? (what else could be captioned in the future/by integrators?)

A follow-up of https://github.com/ckeditor/ckeditor5/issues/12165


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

oleq avatar Aug 03 '22 11:08 oleq

  • Where do we implement this? Both features are in different packages (ckeditor5-table and ckeditor5-image)

No idea :D ckeditor5-widget?

  • Should we make is extendable? (what else could be captioned in the future/by integrators?)

If we'd use MultiCommand then yes, we could make it extensible.

Reinmar avatar Aug 03 '22 11:08 Reinmar

If someone actually works on it, it would be nice to have in mind https://github.com/ckeditor/ckeditor5/issues/12194.

Dumluregn avatar Aug 03 '22 12:08 Dumluregn

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Sep 30 '23 05:09 CKEditorBot

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Oct 31 '23 05:10 CKEditorBot