ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

ContextualBalloon#add does not respect withArrow option

Open scofalik opened this issue 3 years ago • 5 comments

📝 Provide detailed reproduction steps (if any)

In ContextualBalloon#add(), using withArrow option does not change anything. This is because it is overwritten later on by this.view.pin():

	_showView( { view, balloonClassName = '', withArrow = true, singleViewMode = false } ) {
		this.view.class = balloonClassName;
		this.view.withArrow = withArrow;

		this._rotatorView.showView( view );
		this.visibleView = view;
		this.view.pin( this._getBalloonPosition() );
		this._fakePanelsView.updatePosition();

		if ( singleViewMode ) {
			this._singleViewMode = true;
		}
	}

An easy fix would be to move this.view.withArrow = withArrow; below this.view.pin():

	_showView( { view, balloonClassName = '', withArrow = true, singleViewMode = false } ) {
		this.view.class = balloonClassName;

		this._rotatorView.showView( view );
		this.visibleView = view;
		this.view.pin( this._getBalloonPosition() );
		this.view.withArrow = withArrow;
		this._fakePanelsView.updatePosition();

		if ( singleViewMode ) {
			this._singleViewMode = true;
		}
	}

scofalik avatar Jul 20 '22 09:07 scofalik

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Sep 30 '23 05:09 CKEditorBot

withArrow is still not honoured. can we get this fixed?

Kaviarasi avatar Oct 30 '23 06:10 Kaviarasi

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Oct 29 '24 23:10 CKEditorBot

We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

CKEditorBot avatar Nov 29 '24 23:11 CKEditorBot

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot avatar Dec 03 '25 23:12 CKEditorBot