ContextualBalloon#add does not respect withArrow option
📝 Provide detailed reproduction steps (if any)
In ContextualBalloon#add(), using withArrow option does not change anything. This is because it is overwritten later on by this.view.pin():
_showView( { view, balloonClassName = '', withArrow = true, singleViewMode = false } ) {
this.view.class = balloonClassName;
this.view.withArrow = withArrow;
this._rotatorView.showView( view );
this.visibleView = view;
this.view.pin( this._getBalloonPosition() );
this._fakePanelsView.updatePosition();
if ( singleViewMode ) {
this._singleViewMode = true;
}
}
An easy fix would be to move this.view.withArrow = withArrow; below this.view.pin():
_showView( { view, balloonClassName = '', withArrow = true, singleViewMode = false } ) {
this.view.class = balloonClassName;
this._rotatorView.showView( view );
this.visibleView = view;
this.view.pin( this._getBalloonPosition() );
this.view.withArrow = withArrow;
this._fakePanelsView.updatePosition();
if ( singleViewMode ) {
this._singleViewMode = true;
}
}
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.
withArrow is still not honoured. can we get this fixed?
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.
We've closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.