ckeditor5-react
ckeditor5-react copied to clipboard
Setting data of any root with MultiRoot editor results in revision history marking all roots as changed
Reproduction steps
It can be done in multiple ways, the fastest for me was by using collaboration samples.
- Checkout collaboration samples repo and follow setup instructions.
- In real-time-collaboration-editor-multi-root-for-react expose
dataandsetDatareturned byuseMultiRootEditor. This can be done by modifying this line as:
const { data, setData, editableElements, toolbarElement, attributes } = useMultiRootEditor( editorProps );
window.setData = setData;
window.data = data;
- Run the sample with
yarn && yarn dev. - Go to http://localhost:5173/.
- Open dev console, paste and execute
window.setData({...window.data, header: '123123'}). - Go to editor revision history.
Expected
Only header root is marked as changed.
Actual
All roots are marked as changed:
A bit of context
This happens because setData returned from useMultiRootEditor hook, expects all roots to be passed (since it diffs root list enabling to add/remove them) and existing roots are just updated with passed data, even if it's the same. Such update results in each root model data to be wiped out and re-added which is interpreted by revision history as complete data replace (since it works on model operations and does not diff data changes).