ckeditor5-react icon indicating copy to clipboard operation
ckeditor5-react copied to clipboard

Published 20 hours ago • verified publisher icon ckeditor

shouldComponentUpdate incorrectly async

Open namoscato opened this issue 2 years ago • 0 comments

@imjordanxd mentioned this in https://github.com/ckeditor/ckeditor5-react/commit/b17ddd4e7b6d0b3e51a1b52fc8f828cf51c8639c#r73940156, and I just wanted to surface it as an issue.

https://github.com/ckeditor/ckeditor5-react/pull/310 made a change that made shouldComponentUpdate async, which seems incorrect? It should return a boolean per React documentation.

namoscato avatar Jun 01 '22 21:06 namoscato