ckeditor5-dev icon indicating copy to clipboard operation
ckeditor5-dev copied to clipboard

Published 20 hours ago • verified publisher icon ckeditor

Bumped Puppeteer to the latest version and switched to the new headless mode

Open psmyrek opened this issue 1 year ago • 4 comments

Suggested merge commit message (convention)

Internal: Bumped Puppeteer to the latest version and switched to the new headless mode. New Puppeteer includes a fix for handling <iframe> in manual tests that no longer throws connection timeout. Closes ckeditor/ckeditor5#14906.

Additional information

To do list before merging this PR:

  • [x] Wait for new Puppeteer, probably v21.2.0: https://github.com/puppeteer/puppeteer/releases.
  • [x] Use new version in this PR.
  • [ ] Check if issue in ckeditor/ckeditor5#14906 is fixed.

psmyrek avatar Sep 05 '23 08:09 psmyrek

Once we merge the PR, it would be good to revert this change: https://github.com/ckeditor/ckeditor5/commit/a5e3a0336595a69085360e0b5b24289379d2f6d9.

pomek avatar Sep 06 '23 10:09 pomek

Coverage Status

coverage: 90.149%. remained the same when pulling 709d9607d042ca493706ed91eeefa0f95ed0300f on fix-crawler-failures-on-ci into 43eabd25001505b8c83574b1842284897840658a on master.

coveralls avatar Sep 13 '23 06:09 coveralls

The error with noselection-iframe seems to be fixed, but now not all pages are visited by the crawler. See some logs from CI:

  • https://app.circleci.com/pipelines/github/ckeditor/ckeditor5/518/workflows/d3cab551-880e-4762-a16f-be3e7a80a2e8/jobs/2157/parallel-runs/0/steps/0-106
  • https://app.circleci.com/pipelines/github/ckeditor/ckeditor5/518/workflows/3c001604-f409-4f04-b7e2-4a3bda6fa85f/jobs/2164/parallel-runs/0/steps/0-106

psmyrek avatar Sep 13 '23 06:09 psmyrek

I did a few more checks:

  • Installed the newest Puppeteer v21.3.6.
  • The new headless: 'new' mode is unstable on CI, but locally it works quite fine. On CI there is always the following error: TargetCloseError: Protocol error (Browser.close): Target closed and Failed to open a new tab - see example job.
  • The old headless: 'old' mode works in the same way as previously: the net::ERR_ABORTED is thrown from the noselection-iframe manual test: see example job.

It seems that we should wait for the new stable Chromium release that contains a fix, and then wait for the new Puppeteer that uses the fixed version of the Chromium.

psmyrek avatar Oct 05 '23 13:10 psmyrek