EditorWatchdog deep import warning

[VagrantAI-c]

I don't know whether this is somewhat relevant, but from last deps version bump angular started to throw next warning when serving app with ckeditor5-angular component:

Warning: Entry point '@ckeditor/ckeditor5-angular' contains deep imports into '.../node_modules/@ckeditor/ckeditor5-watchdog/src/editorwatchdog'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Versions: ckeditor5-angular: 1.2.2 (bumped from 1.2.1) angular: 9.1.0 (bumped from 9.0.4)

Related: https://github.com/angular/angular/issues/35615

[Mgsy]

cc @ma2ciek

[ma2ciek]

I'll check it. But TBH I don't think it's a real issue.

[ma2ciek]

I see it's a new complier warning (IVY).

[ma2ciek]

I tried to update the library compiler but that's not so easy in the current situation.

I'll lower the issue priority as it's not breaking anything and the fix is currently hard to guess.

[ma2ciek]

Hm. that's probably a reason why the production build sometimes fails - #194. :disappointed: I'll have to look closer on it.

[ma2ciek]

I saw just a PR fixing such an issue - nicky-lenaers/ngx-scroll-to#123. And the fix was mainly by updating dev dependencies. So I'll have to work on the #182 soon.

[DerHerrGammler]

+1 I have the issue that the Modul not longer works in Production mode because of the deep mereg warning

[MVDeveloper1]

Same issue here, waiting for a fix.

[tobiasschweizer]

any progress on this?

[sairam59]

Any updates

[ma2ciek]

Unfortunately, the recent update of deps and internal tools for building the library didn't close this issue, but I checked that it should be possible to turn these warnings off by creating the ngcc.config.js file in the project root and specifying the ignorableDeepImportMatchers option - it's described in the angular/angular#35615.

[tobiasschweizer]

@ma2ciek Thanks for the update!

Can you tell if this was the reasons for your production build to fail?

[ma2ciek]

Can you tell if this was the reasons for your production build to fail?

Short answer: no. Our release script was using out-dated Angular utils, which built a library incompatible with Angular 9+ apps. After updating library bundling utils it turned out that the new major version should be released as the bundled library is no longer compatible with Angular 5-8 (hello the beautiful JS world) That's why the https://github.com/ckeditor/ckeditor5-angular/releases/tag/v2.0.1 was released.

[tobiasschweizer]

@ma2ciek Is this related to CommonJS module? This came with Angular 10 and affects the way libs are built.

[huzaifa074]

I'm getting this issue on building the app with build optimizer set to true. It goes away by setting flag to false. But it increases the bundle size.

[nemofalcon]

I have use this code. it has solve my problem.
'@ckeditor/ckeditor5-angular': { ignorableDeepImportMatchers: [ /@ckeditor//, ] }

[eduardorangell]

I have use this code. it has solve my problem. '@ckeditor/ckeditor5-angular': { ignorableDeepImportMatchers: [ /@ckeditor//, ] }

@nemofalcon hello there. Sorry for bothering you, but where you added this code ?

[nemofalcon]

@eduardorangell

[Dzivo]

Create ngcc.config.js and add this:

module.exports = {
  packages: {
    '@ckeditor/ckeditor5-angular': {
      ignorableDeepImportMatchers: [
        /@ckeditor\//,
      ]
    }
  }
}

Any news on this its really anoying :D