ckeditor4 icon indicating copy to clipboard operation
ckeditor4 copied to clipboard

Incorrect dependencies set for the `panelbutton` plugin

Open Comandeer opened this issue 3 years ago • 0 comments

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open http://localhost:1030/tests/plugins/panelbutton/aria
  2. Open console.
  3. Try to open the menu button.

Expected result

The menu opens

Actual result

There is an error in the console:

Uncaught TypeError: CKEDITOR.ui.floatPanel is not a constructor
    at $.createPanel (plugin.js:81:30)
    at $.clickFn [as click] (plugin.js:15:9)
    at Object.execute (plugin.js:167:18)
    at plugin.js:199:14
    at tools.js:929:15
    at Object.callFunction (tools.js:957:20)
    at HTMLAnchorElement.onclick (aria:1:16)

Other details

The panelbutton plugin calls directly the CKEDITOR.ui.floatPanel constructor https://github.com/ckeditor/ckeditor4/blob/058f65bedfa674d166320dfed3e1f4fd17e430a8/plugins/panelbutton/plugin.js#L81

However, the floatpanel plugin is not added to the panelbutton's requires property.

  • Browser: 103.0.5060.53 (Official Build) (x86_64)
  • OS: mac 12.4
  • CKEditor version: 4.5.0+
  • Installed CKEditor plugins: panelbutton

Comandeer avatar Jul 09 '22 23:07 Comandeer