ckeditor4 icon indicating copy to clipboard operation
ckeditor4 copied to clipboard

Published 20 hours ago • verified publisher icon ckeditor

checkDirty() returns true if clicking or editing a widget, but without changing anything

Open spacevoyager78 opened this issue 4 years ago • 3 comments

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://jsfiddle.net/fq2dr3Lc/1/
  2. Select the widget by clicking the drag handler or click inside it to edit it, but don't change anything.
  3. Reload the page

Expected result

Page reloads.

Actual result

Browser asks for confirmation.

Other details

If you select the widget, confirmation appears. If you then click after it, confirmation doesn't appear. If you click inside to edit it, confirmation appears. if you then click after it, confirmation appear also.

  • Browser: Firefox
  • OS: Windows 7
  • CKEditor version: 4.14.1
  • Installed CKEditor plugins: full

spacevoyager78 avatar Sep 29 '20 09:09 spacevoyager78

I can confirm the issue - looks like some artifacts (probably from selection) are different between initial editor content and snapshot took for dirty comparison. Couldn't reproduce on Chrome.

jacekbogdanski avatar Oct 01 '20 13:10 jacekbogdanski

I can reproduce it in Chrome not by selecting the widget, but by clicking inside "title" or "content" editable part, dirty flag is set. But, if you then click below the widget in the empty paragraph, dirty flag is unset again. Also, it's not a problem of the initial editor data, but rather the data just before selecting or clicking inside a widget, please see an updated fiddle where I've put a "reset dirty flag" button: https://jsfiddle.net/j1ueo5b7/

  1. Type something below the widget, in the empty paragraph
  2. Try to reload the page -> confirmation appears (correct behavior). Hit cancel in reloading.
  3. Click "Reset dirty flag" button.
  4. Click inside an editable part of the widget.
  5. Try to reload the page -> confirmation appears (wrong behavior).

Summary: Firefox: Selecting a widget, sets the dirty flag. Deselecting the widget, unsets the dirty flag. Clicking in editable part, sets the dirty flag and is always set from that point no matter what I do. Chrome: Selecting a widget, doesn't set the dirty flag. Clicking in editable part, sets the dirty flag. Clicking outside the widget, unsets the flag again.

spacevoyager78 avatar Oct 01 '20 19:10 spacevoyager78

I am able to reproduce on Chrome Version 103.0.5060.134 (Official Build) (64-bit)

cimenta avatar Aug 02 '22 12:08 cimenta