ckeditor4-sdk
ckeditor4-sdk copied to clipboard
Make sure offline SDK builder skips File Upload sample
CKFinder should not be a part of the downloadable package and samples that use it should not be included in the offline package.
Tricky: what about links to these samples, if they are given in the "Related Features" section? Or inline links in other samples (if these exist)? Should we remove them (will require manual effort) or perhaps create a custom 404 page with a note saying that "this particular sample is not available in the offline package, try the online version instead"?
I would keep it but mark it with a notice that this sample does not work in offline mode. This will be totally understandable, since it talks about uploading.
+1 for solution proposed by @Reinmar.
"This sample requires CKFinder for PHP to run which is not included in the offline SDK (...)". Regarding samples itself - the rest may be even left untouched, so if anyone installs CKFinder for PHP in the ckfinder folder they will work out of the box. Less work for us.
@adelura: Is it possible to add some text to the sample that would only appear in the offline SDK build?
I can implement something like removing elements in each sample which are wrong for specific version (offline or online).
If there is a element like this:
<div data-sdk-version="offline" >This element will be visible only in offline version</div>
I will remove it for online version.
Done. You can now use the attribute on major
.
Oups. The issue was about a specific sample. Reopening.