ckeditor4-sdk icon indicating copy to clipboard operation
ckeditor4-sdk copied to clipboard

Convert all line endings to CRLF in release version

Open Reinmar opened this issue 11 years ago • 4 comments

There's a lot of code with CRLFs.

Reinmar avatar Oct 16 '14 10:10 Reinmar

Let's handle in this ticket just the release process.

After a short discussion we decided to enforce CRLF in release version. Make sure to process only selected text files (html, css, js, txt, md etc.) to not break binary files (e.g. images).

wwalc avatar Oct 16 '14 11:10 wwalc

@wwalc https://www.npmjs.org/package/grunt-eol may do the trick.

oleq avatar Oct 16 '14 11:10 oleq

I created a t/100 branch where the grunt build tasks is using grunt-eol. Unfortunately, due to hardcoded compression in app.js, it is impossible to do the replacement when the zip file is created.

We should switch to https://www.npmjs.org/package/grunt-contrib-compress with creating the packages.

wwalc avatar Oct 20 '14 08:10 wwalc

Looks like this will be handled in #55.

wwalc avatar Oct 20 '14 08:10 wwalc