ckanext-scheming icon indicating copy to clipboard operation
ckanext-scheming copied to clipboard

Organization try to use scheming.css by href, this cause 404

Open ccancellieri opened this issue 4 years ago • 3 comments

When we use scheming for customized organization formats and we go over an organization the template is loaded:

https://github.com/ckan/ckanext-scheming/blob/d441d2dee72a7382a73de4185b01fae4b2d37473/ckanext/scheming/templates/organization/edit_base.html#L5

I think that this line is causing the issue, is redundant and can be deleted (maybe also the whole template can go...

Moreover we are already correctly importing the scheming.css thanks to:

https://github.com/ckan/ckanext-scheming/blob/master/ckanext/scheming/2.8_templates/scheming/snippets/scheming_asset.html

and https://github.com/ckan/ckanext-scheming/blob/d441d2dee72a7382a73de4185b01fae4b2d37473/ckanext/scheming/templates/base.html#L5

What do you think?

ccancellieri avatar Apr 22 '21 10:04 ccancellieri

Hi @wardi, @wood-chris,

Do you need help closing this issue?

Regards

Patrick1Rhode avatar Jun 14 '21 10:06 Patrick1Rhode

@Patrick1Rhode sure, a PR would be welcome

wardi avatar Jun 14 '21 13:06 wardi

I guess it's still an issue and maybe the PR should be merged.

mutantsan avatar Sep 14 '21 13:09 mutantsan