ckanext-scheming icon indicating copy to clipboard operation
ckanext-scheming copied to clipboard

Published 20 hours ago • verified publisher icon ckan

Update resource_form.html

Open rbvictor opened this issue 8 years ago • 3 comments

When I try to create a dataset with no resources, the error 'You must add at least one data resource' does not appear in the resource_form. When I analyzed lines 656 to 668 in https://github.com/ckan/ckan/blob/master/ckan/controllers/package.py#L656-L668 , I realized that the error dict is empty and only the error_summary is assigned the message. That is why I suggest checking and adding the error summary in this scheming snippet as well. I tried to extend this snippet otherwise, but I didn't succeed. With this patch, I got the error message to reappear on the page.

rbvictor avatar Jul 27 '16 23:07 rbvictor

I cannot access circleci to check the failed tests, but I only added minor changes.

rbvictor avatar Jul 27 '16 23:07 rbvictor

The tests fails because of https://github.com/ckan/ckan/pull/3181. This will be fixed when they release 2.5.3

erlingbo avatar Sep 07 '16 11:09 erlingbo

Any chance this can be re-run against a newer ckan version? Looks like it was last tried about a year ago against ckan release-v2.3-latest.

boykoc avatar Sep 07 '18 21:09 boykoc