ckanext-harvest icon indicating copy to clipboard operation
ckanext-harvest copied to clipboard

Update harvester source commands

Open frafra opened this issue 3 years ago • 6 comments

README.md does not reflect current options:

Usage: ckan harvester source [OPTIONS] COMMAND [ARGS]...

  Manage harvest sources

Options:
  --help  Show this message and exit.

Commands:
  clear          Clears all datasets, jobs and objects related to a harvest...
  clear-history  If no source id is given the history for all harvest...
  create         Create new harvest source.
  remove         Remove (deactivate) a harvester source, whilst leaving any...
  show           Shows a harvest source.

frafra avatar Nov 16 '21 15:11 frafra

@frafra In my opinion the information about the command line CKAN commands in the README.rst in this repository is equal to the commands usage documentation in harvester.py and corresponds to the implementation. Or did I missed something?

seitenbau-govdata avatar Nov 29 '21 20:11 seitenbau-govdata

@frafra In my opinion the information about the command line CKAN commands in the README.rst in this repository is equal to the commands usage documentation in harvester.py and corresponds to the implementation. Or did I missed something?

It does not, from what I see.

frafra avatar Nov 29 '21 23:11 frafra

README.md does not reflect current options:

Usage: ckan harvester source [OPTIONS] COMMAND [ARGS]...

  Manage harvest sources

Options:
  --help  Show this message and exit.

Commands:
  clear          Clears all datasets, jobs and objects related to a harvest...
  clear-history  If no source id is given the history for all harvest...
  create         Create new harvest source.
  remove         Remove (deactivate) a harvester source, whilst leaving any...
  show           Shows a harvest source.

You are referencing to a README.md file, but in the repository is only a README.rst file. The file extension differs. And the usage string in harvester.py is different to your pasted excerpt.

seitenbau-govdata avatar Nov 30 '21 21:11 seitenbau-govdata

Both README.rst and the docstring do not reflect what I see from the command line, which is what I posted in the first comment, which is the implementation.

frafra avatar Dec 01 '21 11:12 frafra

@frafra I have realized now that you mean the new click commands cli.py in combination with CKAN 2.9. At the moment the README.rst covers only the paster command harvester.py. But they are even more different than only the source command, so I would suggest to add the click commands usage info additionally to the paster command usage info on the README.rst.

seitenbau-govdata avatar Dec 01 '21 17:12 seitenbau-govdata

Sorry for the confusion. My PR is incomplete indeed.

frafra avatar Dec 01 '21 18:12 frafra