ckanext-googleanalytics icon indicating copy to clipboard operation
ckanext-googleanalytics copied to clipboard

Question: does it track DataStore API usage?

Open MrkGrgsn opened this issue 9 years ago • 5 comments

Does this track DataStore API usage? My read of the code is that it doesn't; I can't see it overriding the datastore actions mapping anywhere, but I just wanted to confirm.

MrkGrgsn avatar Oct 20 '16 04:10 MrkGrgsn

@MrkGrgsn , no, it doesn't

gleb-rudenko avatar Feb 17 '17 10:02 gleb-rudenko

Thanks @gleb-rudenko. It would be neat if this extensions had a plugin interface so that other CKAN extensions that add actions can register those actions for GA tracking.

MrkGrgsn avatar Feb 20 '17 00:02 MrkGrgsn

I'll work on it

gleb-rudenko avatar Mar 27 '17 10:03 gleb-rudenko

Does anyone had chance to use it? It looks quite ok for me. Maybe, @gleb-rudenko , you should add little bit more details about you new function. And, if it supposed to be used by others, remove underscore from it's name PS i just thought about it, after merging your previous PR, so could you please create new one?

smotornyuk avatar May 04 '17 10:05 smotornyuk

@smotornyuk I've used it with datastore_search action and it did send analytics data, however, it couldn't identify event label (el) which should be the value of resource_id I suppose. I think it is related to #39

I would make a PR for this so that it tries to use name_or_id or resource_id if id is unavailable.

anuveyatsu avatar Jul 24 '19 05:07 anuveyatsu