ckanext-archiver icon indicating copy to clipboard operation
ckanext-archiver copied to clipboard

QGOV changes

Open ThrawnCA opened this issue 3 years ago • 6 comments

  • Make compatible with Python 3
  • Use UTC timestamps internally so we don't have conversion problems
  • Delete obsolete archives
  • Don't create archival tasks for changes to uploaded files (they get false positives and they don't need to be archived anyway since they're already stored in CKAN)
  • Integrate with additional Uploader APIs for downloads and metadata if available (see QGOV CKAN fork for details) to enable integration with alternative storage providers such as ckanext-s3filestore
  • Add Flake8 config
  • Add Github Actions workflow
  • Add more tests
  • Move requirements from setup.py to requirements files

ThrawnCA avatar May 26 '21 04:05 ThrawnCA

Let's remove travis configuration completely, it's not really usable anymore. I'll try to review this soonish.

Zharktas avatar May 26 '21 06:05 Zharktas

I'll add github action workflow as a separate PR today, so that the action is run for this PR too.

Zharktas avatar May 26 '21 06:05 Zharktas

@Zharktas What was wrong with the Github Workflow in this pull request?

ThrawnCA avatar May 26 '21 22:05 ThrawnCA

The only thing wrong with it, is that it's not run as you have no permissions for this repository. Now that there is a existing workflow, the pull requests will trigger the workflow. And i would like python3 support as separate pull request as python3 support itself does nothing unless CKAN 2.9 is supported as well. There is mine #73, which might do the rest of it once I have time to finish it.

Zharktas avatar May 27 '21 05:05 Zharktas

Well, this is just a merge of all changes in our fork except build config specific to our repos. If you want to split it, feel free.

I've merged master to resolve the conflicts, though.

ThrawnCA avatar May 27 '21 06:05 ThrawnCA

I approved running github action, as it is required for the first time. I'm all in for improving archiver itself, it just might take awhile to get it merged :)

Zharktas avatar May 27 '21 06:05 Zharktas