ck2plus
mercenary_employer seems to be a weird scope
(TL;DR: It seems to always be the merc, and that gets weird)
Discovered while checking out whether the Validator flagging some added instances of mercenary_employer in an effect scope as incorrect simply was due to it never being used there in vanilla or if it was completely unsupported. I fired a modified version (the relevant part being that the "primary_title" in the immediate block is replaced with "mercenary_employer") of HL.10400 for the merc using the console... and he got the sympathy trait for his own religion group when hired by a character whose capital has a different religion group.
My first thought was that perhaps the scope was a poorly named alternative to "band_creator", which would have been consistent with the effect observed. Wanting to confirm this, I created a simple targeted decision adding 1 prestige to the mercenary_employer. Firing up CK2 again, I did not see what I expected.
The dynamic merc is his own mercenary_employer, it seems. Leaving aside the problems this poses for my specific case, this would mean that several vanilla/CleanSlate uses of mercenary_employer aren't working well; for example, in HL.10400, the weight_multiplier checks if the mercenary_employer is alive -- always true since the merc gets the event -- and if the mercenary_employer is a friend of the merc -- never true since they are the merc -- and thus not really having the weight you'd expect.
It might be worth cleaning up stuff in the mercenary_employer scope in assorted places.
