Caleb Hattingh

Results 130 comments of Caleb Hattingh

> should term_query stem? Maybe. It wraps [`TermQuery`](https://docs.rs/tantivy/latest/tantivy/query/struct.TermQuery.html), so I'd want to know how stemming is handled in tantivy first, before deciding on a path for us.

We do have the fuzzy map in `parse_query`, at least in main: ![image](https://github.com/quickwit-oss/tantivy-py/assets/480395/22726112-3467-4c9a-95c3-5d2073cc2e67)

Yes please that would be great if you can update those type annotations.

> Are these created by hand or by some process? Maybe fixing this is a simple PR I can contribute. Yes created by hand. It would be a simple PR.

Ok making a PR for the missing types now.

If you have time, we would appreciate a working code snippet that is easy to run to reproduce the issue. See http://www.sscce.org/

@Fudge Thanks for looking at this ❤️ The first thing I am most interested to know is whether the deletion behaviour in tantivy-py behaves differently than the upstream tantivy crate....

> there is an indexed flag which needs to be enabled for deletion to work. Is this also how tantivy works? If so, we're not going to change the behaviour...

I have merged #456. This change introduces `delete_documents_by_query()`, which does do tokenization, and `delete_documents_by_term()` which does not do tokenization. The latter is in fact the old `delete_documents()` method, with a...

You didn't provide a reproducer; for future reference, if you supply a reproducer that can be copy-pasted and run, so that a maintainer can test it immediately makes it much,...