Christopher Patton

Results 44 comments of Christopher Patton

Closing due to lack of activity. Feel free to re-open if you want to get this question answered.

While working on #100 I noticed a couple other nit-picky things with `Decode` and `Encode` that I would like to fix: 1. We have run into message length limits, which...

While at it, address this: https://github.com/cloudflare/daphne/pull/473/files#diff-6660c5f7b70da1bf7dd0a22e00b5ee3191e693b9cef73a0fb5aeb31ae514f28cR59

EDITED ~The roughenough client does not appear to implement the VER tag properly:~ cloudflare/roughtime does not implement the VER tag properly. To reproduce: Run the server: ``` [~/github.com/cloudflare/roughtime]$ go run...

I've confirmed interop for batch size of 1 between int08h/roughenough and cloudflare/roughtime, modulo the following discrepancies: 1. int08h/roughenough uses a non-standard version number: should be 0x80000008 2. cloudflare/roughtime incorrectly implements...

Note there may yet be future draft versions before RFC, though I'm hopeful we're close to the final draft as most of the chatter on the NTP mailing list has...

We're aiming to add draft 10 support to our server before IETF 120.

Thanks for pointing these out! Please send a PR at your convenience.

> I'm going to approve to unblock, but maybe prio should change to have more smaller traits to avoid situations like this? I'm not super familiar with prio but methods...

> Another high-level question: How does this interact with ECH? > > 1. Is the the extension present in both the inner and outer handshake? > > 2. If so,...