cookiecutter-hypermodern-python icon indicating copy to clipboard operation
cookiecutter-hypermodern-python copied to clipboard

Autocommit when black/reorder imports do the work

Open staticdev opened this issue 3 years ago • 2 comments

I found a GA that could do the trick:

https://github.blog/2020-09-17-github-action-hero-stefan-zweifel-and-git-auto-commit/

Nice to have?

staticdev avatar Sep 21 '20 19:09 staticdev

Thanks, this looks interesting. This action could be run after the pre-commit session in the Tests workflow. ~~Does it handle external contributions gracefully? The action should not fail the workflow if the contributor has not made their branch writable for maintainers.~~ Update: Never mind, the workflow would fail anyway if pre-commit applied fixes.

cjolowicz avatar Sep 22 '20 04:09 cjolowicz

I am not sure, we would have to test.

On Tue, 22 Sep 2020, 01:40 Claudio Jolowicz, [email protected] wrote:

Thanks, this looks interesting. This action could be run after the pre-commit session in the Tests workflow. Does it handle external contributions gracefully? The action should not fail the workflow if the contributor has not made their branch writable for maintainers.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cjolowicz/cookiecutter-hypermodern-python/issues/548#issuecomment-696504748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBF2IWPX6DX2OY2B52S73SHATFPANCNFSM4RU43TOA .

staticdev avatar Sep 22 '20 12:09 staticdev